Skip to content

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Feb 21, 2023

This is to pick up TimelyDataflow/timely-dataflow#505, which fixes a memory leak in environmentd.

Motivation

  • This PR fixes a previously unreported bug.

Memory is leaked in the read_capabilities maintained for "retained metrics relations" due to MutableAntichain not consolidating its contents eagerly enough. See MaterializeInc/database-issues#5166.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way) and therefore is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • N/A

This is to pick up
TimelyDataflow/timely-dataflow#505, which fixes
a memory leak in environmentd.
@teskje teskje merged commit e0148c9 into MaterializeInc:main Feb 21, 2023
@teskje teskje deleted the upgrade-timely branch February 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants