Skip to content

Conversation

@CMCDragonkai
Copy link
Member

Description

According to @tegefaulkes this is the correct way of setting polykeyWorker.js. I've made the change here. Can you check if windows/linux builds work? If so, merge this PR.

@tegefaulkes
Copy link
Contributor

Runs fine in WSL. But I think a change in the master is messing up the .exe.
Level is failing to create the database file since the path is invalid. I think you changed the path for that to use /tmp/ at some point?

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Aug 17, 2021

Yeah, That absolute path is not valid in windows.

- const dir = argv[2] ?? '.';
+  const dir = argv[2] ?? '/tmp';
  await testLevel(dir);

Otherwise this PR is fine. @CMCDragonkai

@CMCDragonkai
Copy link
Member Author

Yea I forgot about that. Instead of using /tmp. Use https://nodejs.org/api/os.html#os_os_tmpdir instead. Please make the change and merge.

@tegefaulkes
Copy link
Contributor

On it.

@tegefaulkes tegefaulkes merged commit dcd61d4 into master Aug 17, 2021
@tegefaulkes tegefaulkes deleted the pkgscripts branch August 17, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants