Skip to content

Conversation

@tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jun 3, 2024

[ci skip]

Description

This PR addresses the issue where stopping a QUICServer with a starting QUICConnection will wait out the timeout of the connection without forcing it to stop. The solution to this is to provide QUICServer wide abort signal to be passed into QUICConnections when they're being created. This abort signal has been modified with setMaxListiners to prevent warnings for more than 11 listeners since it's a 1 signal to many connections.

The QUICClient doesn't need the same treatment for two reasons. First, there is 1 connection per client. Second, it's not possible to stop the client without fully creating the client and connection first.

Issues Fixed

Tasks

  • 1. Abort starting connections when quicServer.stop is called with force: true.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jun 3, 2024
@linear
Copy link

linear bot commented Jun 3, 2024

@tegefaulkes tegefaulkes merged commit 486cfeb into staging Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Server should abort starting connections when stopping with force: true

2 participants