fix: we now abort starting connection when stopping the QUICServer
#103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Description
This PR addresses the issue where stopping a
QUICServerwith a startingQUICConnectionwill wait out the timeout of the connection without forcing it to stop. The solution to this is to provideQUICServerwide abort signal to be passed intoQUICConnections when they're being created. This abort signal has been modified withsetMaxListinersto prevent warnings for more than 11 listeners since it's a 1 signal to many connections.The
QUICClientdoesn't need the same treatment for two reasons. First, there is 1 connection per client. Second, it's not possible to stop the client without fully creating the client and connection first.Issues Fixed
force: true#102Tasks
quicServer.stopis called withforce: true.Final checklist