Gracefully handle certain QUICSocket.send errors
#89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the send failures by taking any send specific errors and passing them back to the connection to be handled. Any errors such as bad arguments results in the connection throwing the problem proactivity. Any network failures are generally ignored and the Connections are left to time out. This allows for the network to drop for a short amount of time without failure of the connection and streams. [ci skip]
There were a few things here. For starters some of the new tests had some dumb config. A mistake on my part. The other part is that the `send` throws different errors depending on platform and context. I could only reasonably track it down based on testing in the CI... There are 3 main errors we're sending back to the connection to be dealt with.
tegefaulkes
force-pushed
the
feature-socket-errors
branch
from
8876106 to
6b62491
Compare
Contributor
Author
|
There was mention of some odd behaviour when switching wifi networks which needs to be looked into. But I'll make a new issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is take two of the previous PR at #86
This PR attempts to fix the problem with socket send errors not being handled properly when they're specific to the connection triggering the send. It also handles basic network dropouts.
The previous PR had some issues with platform specific behaviour with the send errors. The 3 different platforms gave 3 different error codes for invalid IP based on how the socket was bound.
Issues Fixed
js-quichard crashes when bound to loopback and creating connection to an external address. #78Tasks
Final checklist