-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
developmentStandard developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History ManagementSecret Vault Sharing and Secret History Managementr&d:polykey:supporting activitySupporting core activitySupporting core activity
Description
Specification
In the RPC system, specifically the server side. The handler can be cancelled or timed out from the ctx: ContextTimed. This will result in a signal that SHOULD cause the handler to end immediately. It is possible for the handler to ignore this however.
Currently there is some logic what will wait a certain delay after cancellation and then force close the stream the handler was handling. This logic needs to be removed.
The reasoning is, we should allow for an arbitrary delay in handling a signal. But also, programmatic problems such as deadlocks should not be silently handled by a fail safe such as this. It should be found and dealt with during testing.
Additional context
Tasks
- Remove grace timeout timer logic from the RPC system.
- Remove any tests that test this and update ones that depend on it.
Metadata
Metadata
Assignees
Labels
developmentStandard developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History ManagementSecret Vault Sharing and Secret History Managementr&d:polykey:supporting activitySupporting core activitySupporting core activity