Skip to content

Move lcov 3.6 #10452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: mbedtls-3.6
Choose a base branch
from
Open

Move lcov 3.6 #10452

wants to merge 3 commits into from
+5 −92

Conversation

@bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Oct 15, 2025 •
edited
Loading

Description

Remove lcov.sh as this will be moved to the framework contributes Mbed-TLS/mbedtls-framework#93

This PR is part of a multistage PR, however the code changes involved appear to not effect the CI so it can be merged in any order. However it is suggested it is merged in the following order.

  1. Add adapted lcov.sh to the framework mbedtls-framework#224
  2. Update lcov.sh paths in make files TF-PSA-Crypto#536
  3. Move lcov 3.6 #10452
  4. Remove lcov.sh as this will be moved to the framework #10450

Parameritised job: https://jenkins-mbedtls.oss.arm.com/job/mbed-tls-pr-test-parametrized/588/

PR checklist

This was referenced Oct 15, 2025
Open
Merged
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits needs-preceding-pr Requires another PR to be merged first labels Oct 15, 2025
@bjwtaylor bjwtaylor marked this pull request as ready for review October 15, 2025 08:42
@valeriosetti valeriosetti self-requested a review October 16, 2025 11:37
@bjwtaylor bjwtaylor mentioned this pull request Oct 20, 2025
Merged
4 tasks
@mpg mpg removed the needs-preceding-pr Requires another PR to be merged first label Oct 24, 2025
mpg
mpg requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except I think we need to update the framework pointer in order for the script to be present in its new location.

@mpg mpg added needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Oct 24, 2025
mpg
mpg previously approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriosetti valeriosetti valeriosetti approved these changes

@mpg mpg mpg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

needs-review Every commit must be reviewed by at least two team members, priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjwtaylor @mpg @valeriosetti