USE_PSA_CRYPTO: update elliptic curve encoding #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
mbed TLS team
needs-review
gilles-peskine-arm
force-pushed
the
psa-streamline_encodings-types_and_curves-ls
branch
from
bdf6d80 to
b314414
Compare
gilles-peskine-arm
force-pushed
the
psa-streamline_encodings-types_and_curves-ls
branch
from
b314414 to
3bac2d0
Compare
AndrzejKurek
previously approved these changes
Dec 31, 2019
mpg
removed
the
needs-review
|
Note: CI is passing except for the API-ABI check, which is expected to fail as this PR indeed changes the API by updating the crypto submodule to a version with a new API. |
gilles-peskine-arm
dismissed stale reviews from mpg and AndrzejKurek
via
8a87d2b
gilles-peskine-arm
force-pushed
the
psa-streamline_encodings-types_and_curves-ls
branch
2 times, most recently
from
8a87d2b to
1955b5f
Compare
|
I rebased to not have a conflict in the submodule update commit and to get up-to-date CI results. |
|
The CI is still passing except the API/ABI check as expected, as it's kinda the point of this PR. |
gilles-peskine-arm
force-pushed
the
psa-streamline_encodings-types_and_curves-ls
branch
from
1955b5f to
edf00ce
Compare
|
CI is passing on HEAD except for a known flaky DTLS test case. We'll need to do another final round of CI after updating the crypto submodule once the crypto PR is merged. |
Previously in d875285: * Mbed-TLS#333: Streamline PSA key type encodings: prepare * Mbed-TLS#323: Initialise return values to an error Previously in dbcb442: * Mbed-TLS#291: Test MBEDTLS_CTR_DRBG_USE_128_BIT_KEY * Mbed-TLS#334: Fix some pylint warnings Previously in ceceedb: * Mbed-TLS#348: Bump version to Mbed TLS 2.20.0 and crypto SO version to 4 * Mbed-TLS#354: Fix incrementing pointer instead of value In this commit: * Mbed-TLS#349: Fix minor defects found by Coverity * Mbed-TLS#179: Add option to build SHA-512 without SHA-384 * Mbed-TLS#327: Implement psa_hash_compute and psa_hash_compare * Mbed-TLS#330: Streamline PSA key type and curve encodings
Adapt to the change of encoding of elliptic curve key types in PSA crypto. Before, an EC key type encoded the TLS curve identifier. Now the EC key type only includes an ad hoc curve family identifier, and determining the exact curve requires both the key type and size. This commit moves from the old encoding and old definitions from crypto/include/mbedtls/psa_util.h to the new encoding and definitions from the immediately preceding crypto submodule update.
gilles-peskine-arm
force-pushed
the
psa-streamline_encodings-types_and_curves-ls
branch
from
edf00ce to
4245980
Compare
gilles-peskine-arm
added
needs-review
|
The crypto PR is merged. I've updated the crypto submodule update commit in this PR for a final round of CI and review. |
Patater
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
LGTM
Crypto submodule is now pointing to the current https://github.com/ARMmbed/mbed-crypto/tree/development, so no final updates should be required before merging (barring any other issues found in code review).
AndrzejKurek
approved these changes
Jan 31, 2020
|
CI passed except for the expected API changes. |
Patater
removed
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the SSL client code for ECDH using PSA crypto to the new elliptic curve key type encoding in ARMmbed/mbed-crypto#330.
This pull request and ARMmbed/mbed-crypto#330 need to be merged close together because the crypto PR breaks mbedtls. To merge: