[Backport 2.16] Fix incrementing pointer instead of value #3007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced by a hasty search-and-replace that didn't account for C's operator precedence when changing those variables to pointer types.
mpg
added
bug
mbed TLS team
needs-review
2 tasks
yanesca
approved these changes
Jan 24, 2020
gilles-peskine-arm
approved these changes
Jan 27, 2020
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport to Mbed TLS 2.16 of ARMmbed/mbed-crypto#354
In addition to the original, it has a ChangeLog entry. Reviewers, please review carefully that this entry correctly reflects the security impact of the issue.
TODO