Improve stdin, stdout, and stderr redirection in PythonQt
#286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the conditions in setRedirectStdInCallbackEnabled to correctly check for the presence of 'pythonqt_stdin' and 'pythonqt_original_stdin' attributes. This ensures proper redirection of stdin. (cherry picked from commit commontk/PythonQt@ddecb44)
This improves the PythonQt module by adding functionality to redirect stdout and stderr to custom callbacks. It includes methods to enable or disable redirection and to check if redirection is currently enabled. (cherry picked from commit commontk/PythonQt@3d3943f)
This fixes a build error on Windows by renaming the 'stdout' variable to `sys_stdout' to avoid conflicts with system headers. (cherry picked from commit commontk/PythonQt@5487c61)
usiems
approved these changes
Sep 1, 2025
jcfr
deleted the
backport-commontk/fix-stdout-stderr-redirection-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces and fixes the handling of standard stream redirection in the PythonQt module.
setRedirectStdInCallbackEnabledto ensure properstdinredirection.stdoutandstderrto custom callbacks.Note
For reference, those patches were developed in the context of the
commontk/PythonQtfork.Cherry picked from commits: