chore: Replace deprecated Qt macros and Improve const correctness #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
replace-deprecated-macros-and-improve-const-correctness
branch
from
c4779e1 to
111c4eb
Compare
As of Qt 5.7, `foreach` and `Q_FOREACH` macros are deprecated, and C++11 range-based for loops are preferred. Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
This change improves const correctness by using `const` references in range-based for loops and other relevant places.
jcfr
force-pushed
the
replace-deprecated-macros-and-improve-const-correctness
branch
from
111c4eb to
5e2be3f
Compare
mrbean-bremen
approved these changes
Sep 26, 2025
usiems
approved these changes
Sep 26, 2025
jcfr
deleted the
replace-deprecated-macros-and-improve-const-correctness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two main changes:
foreachandQ_FOREACHmacros with C++11 range-based for loops as recommended by Qt 5.7+.constreferences in range-based for loops and other relevant places.