-
Notifications
You must be signed in to change notification settings - Fork 46
Strand-filter and strand-pagination components. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strand-filter and strand-pagination components. #81
Conversation
…on rules, which will become available in the strand-filter (comparison dropdown). The same set of rules will be used in searchable behavior as well.
…dependencies, or also alter configuration objects or any factories. When applied this behavior, user can get injector with method this.getInjector(); and use it's register and resolve dependencies methods. TODO: Write a article regarding this if approved.
…ta-provider component. And can be used to actually compute the rows to be shown for current page.
…et with the help of various comparison rules. Comparison rules can be addded through Strand-Injector or ComparisonRulesProvider. The behavior is capable of applying hierarchical search conditions on the data. TODO:Need a good article to explain how it works.
…will be no visual appearance of this component. But user can use this component whenever data processing is needed. Also, this will keep UI logic completely different from data processing.
…datasets at client-side which can be then paginated through strand-data-provider. Strand-filter uses ComparisonFunctions to compare the items to yield the filter result.
…es across the application.
… of paging buttons. And if used with strand-data-provider, can be attached to any component with data.
…d automatically by gulp task? Not sure..)
|
A large amount of code exists for the majority of this. see mm-sync, mm-ajax, request.html and the ajax plugin system which handles pagination |
| @@ -0,0 +1,52 @@ | |||
| { | |||
| "name":"mm-filter", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out strand-array-munge
|
@dlasky I am taking this oportunity to thank MediaMath for offering such a scalable library to community. I enjoyed using these controls. mm-sync, mm-ajax and ajax plugin is dealing with serverside communication. The components I came up would be more of data-source agnostic. I believe, this would help users experience the strand controls in the same way irrespective of where the data is coming, (e.g. client side, localstorage, server or anything like pouchdb/indexdb etc) Strand-pagination and strand-filter are only providing the UI making no calls to any data source. But at the same time, it integrates with Strand-data-component which handles data processing like actual searching ( in case of strand-filter) . We can extend strand-data-component to communicate with mm-ajax and mm-sync internally with more configurations. However, I may be missing something or be on the wrong track. Please guide in this case. I would like to know your views. |
|
I think thats partially a consequence of pushing too much stuff in a single PR, we try to separate them by a single component, or in extreme cases a tightly coupled set of components that are generally parent > child of eachother. In terms of UX we don't want to allow for pagination. You'll notice that The search stuff in particular is entirely to opinionated about data and is better left to the client application. |
|
closing as stale |
Hi,
I have added few components for like strand-injector, strand-data-provider (for any processing of data and UI seperation), strand-pagination, strand-filter.
Please let me know in case, I missed any step or any code-changes or architectural changes required.
I will quickly implement those.
Thanks and Regards,
Ganesh Nemade.