Skip to content

Conversation

CSLiuPeng
Copy link
Contributor

@CSLiuPeng CSLiuPeng commented Jul 29, 2025

Description

Summary: This is a evaluation code for locomo dataset.

Fix: Not yet

Docs Issue/PR: Not yet

Reviewer: @Nyakult

Checklist:

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (if applicable) | 我已在 MemOS-Docs 中创建了相关的文档 issue/PR(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

@CSLiuPeng CSLiuPeng changed the title Dev push locomo rag eval code Jul 29, 2025
@tangg555 tangg555 requested a review from Duguce August 1, 2025 04:34
response_time = str(item["response_time"])
search_context = str(item["context"])

# Skip category 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skip cate5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In locomo10_rag.json, the dataset don't have answer field where category is 5.


return chunks, embeddings

def split_chunks2(self, message_content, chunk_size):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a second method to split chunks

@CSLiuPeng CSLiuPeng requested a review from Nyakult August 1, 2025 07:29
Copy link
Contributor

@Nyakult Nyakult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fridayL fridayL merged commit 1718b64 into MemTensor:dev Aug 13, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants