Skip to content

Conversation

Duguce
Copy link
Contributor

@Duguce Duguce commented Jul 7, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 16:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces example configuration and documentation updates for the evaluation framework, modernizes dependency management, and consolidates memory backend handling by removing legacy code.

  • Added new dependencies to pyproject.toml for evaluation configs, environment loading, and model support.
  • Refactored the get_client and search/response scripts to unify the memos backend (removing memos_mos) and added a top_k parameter.
  • Updated CLI choices across scripts and streamlined the README to reference a .env-example and configs-example directory.

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Added scipy, python-dotenv, pydantic, langgraph, and langmem to project dependencies
evaluation/scripts/locomo/locomo_search.py Unified memos backend code, removed legacy blocks, and added top_k parameter support
evaluation/scripts/locomo/locomo_ingestion.py Removed legacy memos and memos_mos ingestion logic; now uses consolidated backend
evaluation/README.md Simplified setup instructions, removed LongMemEval references, and pointed to run_locomo_eval.sh
evaluation/.env-example Introduced an example .env with placeholder API keys and model settings
Comments suppressed due to low confidence (4)

evaluation/scripts/locomo/locomo_ingestion.py:126

  • The ingest_session function no longer includes a branch to handle the memos frame, so data will not be ingested for that backend. Restoring or adding appropriate ingestion logic for memos is needed.
            )

evaluation/scripts/locomo/locomo_search.py:445

  • The help string for the --lib flag lists frameworks but omits langmem (and optionally openai), leading to a mismatch with the choices list. Please update the help text to reflect the actual available options.
        help="Specify the memory framework (zep or memos or mem0 or mem0_graph)",

evaluation/README.md:27

  • [nitpick] The instructions now refer to run_locomo_eval.sh but don't explain where to find or how to configure it, nor the steps for ingestion and search. Consider elaborating the evaluation workflow or including the script contents for clarity.
### LoCoMo Evaluation

pyproject.toml:54

  • [nitpick] Added dependency lines appear to lack the same indentation as existing entries in the [tool.poetry.dependencies] section, which may affect readability or formatting. Consider aligning them with the existing entries.
scipy = "^1.10.1"

@Ki-Seki Ki-Seki self-requested a review July 8, 2025 06:44
Copy link
Member

@Ki-Seki Ki-Seki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is out of date with the base branch. Please merge dev or rebase to stay in sync.


该分支与主分支不同步。请合并dev或rebase以保持同步。

@Duguce

pyproject.toml Outdated
bert-score = "^0.3.13"
scipy = "^1.10.1"
python-dotenv = "^1.1.1"
pydantic = "^2.11.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency (pydantic) can be removed since it is implicitly required by other dependencies and does not need to be explicitly specified. After deleting this line, run poetry lock to update the poetry.lock.


该依赖项(pydantic)可以被移除,因为它已被其他依赖项隐式引入,无需显式指定。删除此行后,请运行 poetry lock 以更新 poetry.lock。

@Duguce
Copy link
Contributor Author

Duguce commented Jul 8, 2025

@Ki-Seki I have solved the two problems.

@Ki-Seki Ki-Seki merged commit 3378fc0 into MemTensor:dev Jul 8, 2025
4 checks passed
tianxing02 pushed a commit to tianxing02/MemOS that referenced this pull request Jul 22, 2025
feat: update installation instructions and add platform compatibility notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants