Skip to content

Conversation

Wujiaxuan007
Copy link
Contributor

fix(example): correct ParsedTaskGoal usage and add unrelated memory for testing

Description

This PR fixes the initialization of ParsedTaskGoal in the example to use the correct fields, and adds both relevant and unrelated memory items to ranked_memories for better demonstration and testing.
No logic changes to the core modules.
No new dependencies.

Fixes # (no related issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change
  • Refactor
  • Documentation update

How Has This Been Tested?

  • Manual test: Ran the example script to ensure it works as expected and unrelated memory is handled properly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Maintainer Checklist

  • closes #xxxx
  • Made sure Checks passed

@Ki-Seki Ki-Seki requested a review from CaralHsi July 8, 2025 08:09
@Ki-Seki
Copy link
Member

Ki-Seki commented Jul 8, 2025

I’ve suggested @CaralHsi to review your PR, but please change the target branch first. We are actively working on the dev branch, not main. Click the edit button to change the target branch.

image

@Ki-Seki Ki-Seki removed the good first issue Good for newcomers label Jul 8, 2025
@Wujiaxuan007 Wujiaxuan007 changed the base branch from main to dev July 8, 2025 08:18
Copy link
Collaborator

@CaralHsi CaralHsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Thank you so much for your contribution to the memos community!
Your work is greatly appreciated.

@CaralHsi CaralHsi merged commit 035eed3 into MemTensor:dev Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants