-
Notifications
You must be signed in to change notification settings - Fork 239
feat(eval): add run locomo eval script #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new shell script to sequentially run all steps of the Locomo evaluation pipeline.
- Adds
run_locomo_eval.sh
to orchestrate ingestion, search, response generation, evaluation, and metric calculation. - Sets default parameters (
LIB
,VERSION
,WORKERS
,TOPK
) and checks exit codes for each step.
@@ -0,0 +1,44 @@ | |||
#!/bin/bash |
Copilot
AI
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding set -euo pipefail
after the shebang to ensure the script exits on any error and detects undefined variables.
Copilot uses AI. Check for mistakes.
echo "Running locomo_ingestion.py..." | ||
CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | ||
if [ $? -ne 0 ]; then | ||
echo "Error running locomo_ingestion.py" | ||
exit 1 | ||
fi | ||
|
||
echo "Running locomo_search.py..." | ||
CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | ||
if [ $? -ne 0 ]; then | ||
echo "Error running locomo_search.py" | ||
exit 1 | ||
fi | ||
|
||
echo "Running locomo_responses.py..." | ||
python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | ||
if [ $? -ne 0 ]; then | ||
echo "Error running locomo_responses.py." | ||
exit 1 | ||
fi | ||
|
||
echo "Running locomo_eval.py..." | ||
python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | ||
if [ $? -ne 0 ]; then | ||
echo "Error running locomo_eval.py" | ||
exit 1 | ||
fi | ||
|
||
echo "Running locomo_metric.py..." | ||
python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION | ||
if [ $? -ne 0 ]; then | ||
echo "Error running locomo_metric.py" | ||
exit 1 | ||
fi |
Copilot
AI
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The error-checking and execution pattern is repeated for each script; consider extracting a helper function (e.g., run_step
) to reduce duplication and improve readability.
echo "Running locomo_ingestion.py..." | |
CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | |
if [ $? -ne 0 ]; then | |
echo "Error running locomo_ingestion.py" | |
exit 1 | |
fi | |
echo "Running locomo_search.py..." | |
CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | |
if [ $? -ne 0 ]; then | |
echo "Error running locomo_search.py" | |
exit 1 | |
fi | |
echo "Running locomo_responses.py..." | |
python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | |
if [ $? -ne 0 ]; then | |
echo "Error running locomo_responses.py." | |
exit 1 | |
fi | |
echo "Running locomo_eval.py..." | |
python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | |
if [ $? -ne 0 ]; then | |
echo "Error running locomo_eval.py" | |
exit 1 | |
fi | |
echo "Running locomo_metric.py..." | |
python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION | |
if [ $? -ne 0 ]; then | |
echo "Error running locomo_metric.py" | |
exit 1 | |
fi | |
# Helper function to run a script and check for errors | |
run_step() { | |
local script=$1 | |
shift | |
echo "Running $script..." | |
"$@" | |
if [ $? -ne 0 ]; then | |
echo "Error running $script" | |
exit 1 | |
fi | |
} | |
run_step "locomo_ingestion.py" CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_ingestion.py --lib $LIB --version $VERSION --workers $WORKERS | |
run_step "locomo_search.py" CUDA_VISIBLE_DEVICES=0 python scripts/locomo/locomo_search.py --lib $LIB --version $VERSION --top_k $TOPK --workers $WORKERS | |
run_step "locomo_responses.py" python scripts/locomo/locomo_responses.py --lib $LIB --version $VERSION | |
run_step "locomo_eval.py" python scripts/locomo/locomo_eval.py --lib $LIB --version $VERSION --workers $WORKERS --num_runs 3 | |
run_step "locomo_metric.py" python scripts/locomo/locomo_metric.py --lib $LIB --version $VERSION |
Copilot uses AI. Check for mistakes.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
run locomo eval
script, submitting a supplement now. @Ki-SekiHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist