This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Fix issue where QR Code Keyring does not expect an empty options object #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which project did you find this dependency in? It appears to be public on GitHub, here: https://github.com/KeystoneHQ/keystone-airgaped-base/tree/master/packages/base-eth-keyring |
|
I think I see what you mean: https://github.com/KeystoneHQ/keystone-airgaped-base/blob/c5e2d06892118265ec2ee613b543095276d5b208/packages/base-eth-keyring/src/BaseKeyring.ts#L290 Good catch, this change makes sense to me. |
Gudahtt
approved these changes
Apr 25, 2022
Lol I don't know why I couldn't find it... |
This was referenced Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I introduced with KeyringController's interface with QR hardware wallet Keyring
@keystonerhq/base-eth-keyringdoesn't appear to be public on github... but if you look in node_modules (node_modules/@keystonehq/base-eth-keyring/dist/base-eth-keyring.cjs.development.js) line 300, thedeserializemethod does not expect an empty object as it'soptsargument.This issue became apparent in the QR hardware keyring tests implemented in Controllers