improve test coverage #140
Conversation
adonesky1
force-pushed
the
improve-test-coverage
branch
3 times, most recently
from
d90b832 to
113a97d
Compare
|
Hey sorry I haven't gotten a chance to look at this lately but I will tomorrow! |
adonesky1
force-pushed
the
improve-test-coverage
branch
from
113a97d to
fe99fa2
Compare
test/index.js
Outdated
| const walletOneSeedWords = | ||
| 'puzzle seed penalty soldier say clay field arctic metal hen cage runway'; | ||
| const walletOneAddresses = ['0xef35ca8ebb9669a35c31b5f6f249a9941a812ac1']; | ||
| const walletOnePrivateAddress = [ |
There was a problem hiding this comment.
Nit: this seems to be a private key, not a private "address". Maybe worth renaming this variable to walletonePrivateKeys.
There was a problem hiding this comment.
Nit: maybe this should be plural since it's an array? I had made it singular at first as well in my comment, but then reconsidered and edited the comment to make ti plural.
test/index.js
Outdated
| origin: 'https://metamask.github.io', | ||
| }; | ||
| const result = await keyringController.signMessage(inputParams); | ||
| expect(result).toBe( |
There was a problem hiding this comment.
Nit: for values like this that a reader can't reasonably be expected to be able to read, it might be worth using an inline snapshot. This communicates to the reader that the value was auto-generated, and makes it easier to update if we do ever intend to change it.
Bump test coverage from:
To:
The remaining coverage is proving a bit tricky. Will come back to it!
Partially fixes: #127