Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@adonesky1
Copy link
Contributor

@metamask/eth-hd-keyring v5.x is now deprecated. v6.0.0 reverts the serialization format from Uint8Arrays (the format introduced in v5) because they don't serialize to JSON nicely, back to an array of utf8 encoded bytes as it was prior to v5.0.0

@adonesky1 adonesky1 requested a review from a team as a code owner January 18, 2023 16:43
@adonesky1 adonesky1 requested a review from Gudahtt January 18, 2023 16:44
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 79d3cd9 into main Jan 18, 2023
@adonesky1 adonesky1 deleted the bump-eth-hd-keyring-version branch January 18, 2023 16:45
@adonesky1 adonesky1 mentioned this pull request Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants