Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@gantunesr
Copy link
Member

Description

This PR updates the general configuration of the KeyringController to module to match the ones from https://github.com/MetaMask/metamask-module-template.

@gantunesr gantunesr added the team-accounts This should be handled by the Accounts Team label May 17, 2023
@socket-security
Copy link

socket-security bot commented May 17, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: @lavamoat/[email protected], [email protected], [email protected], @inquirer/[email protected], [email protected], [email protected]

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Filesystem access ✅ 0 issues
Network access ✅ 0 issues
Shell access ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
No bug tracker ✅ 0 issues
No contributors or author data ✅ 0 issues
No README ✅ 0 issues
Deprecated ✅ 0 issues
New author ✅ 0 issues
Unstable ownership ✅ 0 issues
Non-existent author ✅ 0 issues
Unmaintained ✅ 0 issues
Unpublished package ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@lavamoat/[email protected] None +0 kumavis
[email protected] filesystem, shell, environment +9 rbardini

@gantunesr
Copy link
Member Author

@SocketSecurity ignore-all

@gantunesr gantunesr marked this pull request as ready for review May 18, 2023 01:05
@gantunesr gantunesr requested a review from a team as a code owner May 18, 2023 01:05
legobeat
legobeat previously approved these changes May 19, 2023
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nit-suggestions on the PR template. Address those and looks good to go 👍

@gantunesr gantunesr requested a review from legobeat May 19, 2023 14:47
@gantunesr gantunesr merged commit b9a600a into main May 19, 2023
@gantunesr gantunesr deleted the configuration branch May 19, 2023 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-accounts This should be handled by the Accounts Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants