Skip to content

Conversation

@mcmire
Copy link
Contributor

@mcmire mcmire commented Mar 14, 2024

Currently, code is not automatically linted and tests are not automatically run on pull requests. This happens because the workflows which would perform these steps are not configured to run on pull requests but only on a push to main. This PR modifies the workflows to run on the pull_request event.

@mcmire mcmire requested a review from a team as a code owner March 14, 2024 15:25
@mcmire mcmire force-pushed the run-workflows-on-prs branch from 23f29aa to 42e5932 Compare March 14, 2024 15:37
Currently, code is not automatically linted and tests are not
automatically run on pull requests. This happens because the workflows
which would perform these steps are not configured to run on pull
requests but only on a push to `main`. This PR modifies the workflows to
run on the `pull_request` event.
@mcmire mcmire force-pushed the run-workflows-on-prs branch from 42e5932 to 54a3149 Compare March 14, 2024 15:38
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 09d6568 into main Mar 15, 2024
@Gudahtt Gudahtt deleted the run-workflows-on-prs branch March 15, 2024 14:55
Gudahtt added a commit that referenced this pull request May 10, 2024
* origin/main:
  remove default channel (#73)
  Don't fail overall if Slack announcement fails (#69)
  Improve Dry Run Output (#64)
  5.0.0 (#67)
  Fix Yarn 4 compatibility (#65)
  Disallow publishing packages with version 0.0.0 (#63)
  Run linting and testing GitHub workflows on PRs (#62)
  Enabling MetaMask security code scanner (#60)
  Add Shared Libraries team in codeowners file (#59)
  Update README.md (#56)
  Update README.md (#55)
  Update README.md (#54)
  Bump word-wrap from 1.2.3 to 1.2.4 (#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants