Skip to content

Conversation

@adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Sep 19, 2022

  • CHANGED:

    • Upgrades eth-sig-util (now @metmask/eth-sig-util) from v3.0.0 to v5.0.2. This upgrade contains several updates, including:
      • consolidates the recoverTypedSignature, recoverTypedSignature_v4, recoverTypedSignatureLegacy functions into one that switch on a new version argument.
      • reduces dependency burden, removing secp256k1 and keccak via as dependencies by upgrading from [email protected] to its latest version @ethereumjs/[email protected] which uses lighter noble implementations for crypto functionality. Replaces keccak hashing with keccak256 from ethereum-cryptography/keccak

mcmire
mcmire previously approved these changes Nov 11, 2022
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Just a few suggestions.

@adonesky1 adonesky1 requested a review from mcmire December 19, 2022 23:40
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions, and I'm good!

@adonesky1 adonesky1 requested a review from mcmire December 20, 2022 17:54
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Looks good!

@adonesky1 adonesky1 merged commit 49d3fe6 into main Dec 21, 2022
@adonesky1 adonesky1 deleted the bump-eth-sig-util-version branch December 21, 2022 00:03
gantunesr added a commit that referenced this pull request Feb 10, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
- CHANGED:

- Upgrades `eth-sig-util` (now `@metmask/eth-sig-util`) from v3.0.0 to
v5.0.2. This upgrade contains several updates, including:
- consolidates the recoverTypedSignature, recoverTypedSignature_v4,
recoverTypedSignatureLegacy functions into one that switch on a new
version argument.
- reduces dependency burden, removing `secp256k1` and `keccak` via as
dependencies by upgrading from `[email protected]` to its latest
version `@ethereumjs/[email protected]` which uses lighter `noble`
implementations for crypto functionality. Replaces `keccak` hashing with
`keccak256` from `ethereum-cryptography/keccak`
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
- CHANGED:

- Upgrades `eth-sig-util` (now `@metmask/eth-sig-util`) from v3.0.0 to
v5.0.2. This upgrade contains several updates, including:
- consolidates the recoverTypedSignature, recoverTypedSignature_v4,
recoverTypedSignatureLegacy functions into one that switch on a new
version argument.
- reduces dependency burden, removing `secp256k1` and `keccak` via as
dependencies by upgrading from `[email protected]` to its latest
version `@ethereumjs/[email protected]` which uses lighter `noble`
implementations for crypto functionality. Replaces `keccak` hashing with
`keccak256` from `ethereum-cryptography/keccak`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants