This repository was archived by the owner on Oct 7, 2024. It is now read-only.
bump @ethereumjs/util, @ethereumjs/tx & @metamask/eth-sig-util versions #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
bump-ethereumjs/util
branch
from
ba6e427 to
f9c35d3
Compare
adonesky1
commented
Sep 15, 2022
| const adr = `0x${ethUtil.pubToAddress(pub).toString('hex')}`; | ||
| const r = toBuffer(sgn.slice(0, 66)); | ||
| const s = toBuffer(`0x${sgn.slice(66, 130)}`); | ||
| const v = BigInt(`0x${sgn.slice(130, 132)}`); |
There was a problem hiding this comment.
new version of ecrecover expects v to be a BigInt instead of Buffer: https://npmfs.com/package/@ethereumjs/util/8.0.0/src/signature.ts#L54
kumavis
previously approved these changes
Sep 16, 2022
kumavis
reviewed
Sep 16, 2022
adonesky1
force-pushed
the
bump-ethereumjs/util
branch
from
0caff05 to
b68205c
Compare
kumavis
approved these changes
Sep 16, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGED:
ethereumjs-utilto latest version (now@ethereumjs/util)@metamask/eth-sig-utilto latest version@ethereumjs/txto latest versionAll three of these changes remove dependencies on
secp256k1andkeccakwhich are replaced by lighter noble implementations in upstream dependencies for each.