Skip to content

Conversation

@nishitha-burman
Copy link
Contributor

@nishitha-burman nishitha-burman commented Jan 3, 2022

Fixes #

Docs for Toolkit PR #

What changes to the docs does this PR provide?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (dev for new features, master for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

Other information

@nishitha-burman nishitha-burman changed the title Updated broken link to samples app. Update broken link to samples app. Jan 3, 2022
@nishitha-burman nishitha-burman changed the title Update broken link to samples app. Update broken link to samples app Jan 3, 2022
@opbld30
Copy link

opbld30 commented Jan 3, 2022

Docs Build status updates of commit 45d65bd:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Lottie.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:


> [!div class="nextstepaction"]
> [Try it in the sample app](uwpct://Animations?sample=Lottie)
> [Try it in the sample app](https://www.microsoft.com/en-us/p/lottie-samples/9n3j5tg8ff7f?rtc=1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link we have works, it just brings you to the current sample app doc page we have for Lottie:

image

Though it probably does make sense to link to your full Lottie sample app instead. However, we shouldn't include the locale en-us in the link. Do you have an aka.ms link for the sample app too? That may make it easier to update if needed in the future without having to change the docs again in the future.

@opbld31
Copy link

opbld31 commented Jan 10, 2022

Docs Build status updates of commit e50ebd0:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/animations/Lottie.md ⚠️Warning View Details

docs/animations/Lottie.md

  • Line 17, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'aka.ms/lottiesamples'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
@opbld32
Copy link

opbld32 commented Jan 10, 2022

Docs Build status updates of commit 7e801d7:

✅ Validation status: passed

File Status Preview URL Details
docs/animations/Lottie.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@michael-hawker michael-hawker merged commit ca9b090 into MicrosoftDocs:main Jan 12, 2022
@nishitha-burman nishitha-burman deleted the patch-1 branch January 12, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants