Skip to content

[JitDiff X64] [EgorBo] Optimize BOX+UNBOX for "T? -> T" and "T -> T?" #529

@MihuBot

Description

@MihuBot

Job completed in 16 minutes.
dotnet/runtime#104931

Diffs

Found 266 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 39180228
Total bytes of diff: 39180018
Total bytes of delta: -210 (-0.00 % of base)
Total relative delta: -2.18
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
        -131 : System.Linq.Parallel.dasm (-0.01 % of base)
         -51 : System.Text.Json.dasm (-0.00 % of base)
         -28 : System.Data.Common.dasm (-0.00 % of base)

3 total files with Code Size differences (3 improved, 0 regressed), 256 unchanged.

Top method improvements (bytes):
         -51 (-13.49 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfElement:TryGetValue[System.Nullable`1[int]](byref):ubyte:this (FullOpts)
         -49 (-10.36 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelEnumerable:PerformSequentialAggregation[int,System.Nullable`1[int]](System.Linq.ParallelQuery`1[int],System.Nullable`1[int],ubyte,System.Func`3[System.Nullable`1[int],int,System.Nullable`1[int]]):System.Nullable`1[int] (FullOpts)
         -41 (-69.49 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelQuery`1+<>c__1`1[int,System.Nullable`1[int]]:<Cast>b__1_0(int):System.Nullable`1[int]:this (FullOpts)
         -41 (-69.49 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelQuery`1+<>c__2`1[int,System.Nullable`1[int]]:<OfType>b__2_1(int):System.Nullable`1[int]:this (FullOpts)
         -14 (-27.45 % of base) : System.Data.Common.dasm - System.Data.SortExpressionBuilder`1+<>c__DisplayClass10_0`1[int,System.Nullable`1[int]]:<CloneCast>b__0(System.Nullable`1[int]):System.Object:this (FullOpts)
         -14 (-27.45 % of base) : System.Data.Common.dasm - System.Data.SortExpressionBuilder`1+<>c__DisplayClass10_0`1[int,System.Nullable`1[int]]:<CloneCast>b__1(System.Nullable`1[int]):System.Object:this (FullOpts)

Top method improvements (percentages):
         -41 (-69.49 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelQuery`1+<>c__1`1[int,System.Nullable`1[int]]:<Cast>b__1_0(int):System.Nullable`1[int]:this (FullOpts)
         -41 (-69.49 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelQuery`1+<>c__2`1[int,System.Nullable`1[int]]:<OfType>b__2_1(int):System.Nullable`1[int]:this (FullOpts)
         -14 (-27.45 % of base) : System.Data.Common.dasm - System.Data.SortExpressionBuilder`1+<>c__DisplayClass10_0`1[int,System.Nullable`1[int]]:<CloneCast>b__0(System.Nullable`1[int]):System.Object:this (FullOpts)
         -14 (-27.45 % of base) : System.Data.Common.dasm - System.Data.SortExpressionBuilder`1+<>c__DisplayClass10_0`1[int,System.Nullable`1[int]]:<CloneCast>b__1(System.Nullable`1[int]):System.Object:this (FullOpts)
         -51 (-13.49 % of base) : System.Text.Json.dasm - System.Text.Json.Nodes.JsonValueOfElement:TryGetValue[System.Nullable`1[int]](byref):ubyte:this (FullOpts)
         -49 (-10.36 % of base) : System.Linq.Parallel.dasm - System.Linq.ParallelEnumerable:PerformSequentialAggregation[int,System.Nullable`1[int]](System.Linq.ParallelQuery`1[int],System.Nullable`1[int],ubyte,System.Func`3[System.Nullable`1[int],int,System.Nullable`1[int]]):System.Nullable`1[int] (FullOpts)

6 total methods with Code Size differences (6 improved, 0 regressed), 230502 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions