Skip to content

Conversation

@MonolithProjects
Copy link
Owner

Pull Request Template

Description

Because of different service names for GH Actions Runner running against github.com and GitHub Enterprise Sever (service_name: actions.runner.{{ runner_name }}.service vs service_name: actions.runner._services.{{ runner_name }}.service ) GHES users had to use service_name variable to get their runner service name built correctly. This option was not clear enough and caused confusion.
This PR will deprecate service_name in favor of runner_on_ghes boolean variable. Now the users only need to set if the runner will run on GHES or not and the service name will be crated correctly.

I am keeping also backward compatibility.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Was not tested on GHES.

Destination branch

Create a PR into develop branch

@MonolithProjects MonolithProjects merged commit cff1c8c into develop Sep 5, 2021
@MonolithProjects MonolithProjects deleted the feature/ghes_support branch September 7, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants