Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Because of different service names for GH Actions Runner running against github.com and GitHub Enterprise Sever (
service_name: actions.runner.{{ runner_name }}.servicevsservice_name: actions.runner._services.{{ runner_name }}.service) GHES users had to useservice_namevariable to get their runner service name built correctly. This option was not clear enough and caused confusion.This PR will deprecate
service_namein favor ofrunner_on_ghesboolean variable. Now the users only need to set if the runner will run on GHES or not and the service name will be crated correctly.I am keeping also backward compatibility.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Was not tested on GHES.
Destination branch
Create a PR into
developbranch