Remove pkg_resources #281
Remove pkg_resources #281
Conversation
| req = pkg_resources.Requirement.parse("wrf-python") | ||
| extra_dll_dir = pkg_resources.resource_filename(req, | ||
| "wrf-python/.libs") |
There was a problem hiding this comment.
I think the updated version of this is importlib.resources.path("wrf", ".libs"), which seems to have been added in 3.7. mesonbuild/meson-python#700 includes discussion on a similar topic. This comment and the followup have suggestions, and also say that I should run into any problems in my default development environment, which simplifies checks.
There was a problem hiding this comment.
A guess based on the directory name (and Python doing its own search for imported extension modules) is that this is for the Fortran and OpenMP runtimes, which would be stored there by Windows wheel-packaging machinery, which was your guess. Since I build and install on the same system, I don't need to package those libraries, nor ensure they are on the path.
If you decide conda is the recommended binary distribution system on Windows, that should be irrelevant.
3 participants
Removes deprecated
pkg_resources.This shouldn't cause any problems for the Linux or macOS builds since it was originally used as a workaround for some Windows specific issues tied to
np.distutils. And we no longer rely upondistutilsso in theory removing this shouldn't be an issue there either. Unfortunately, we don't have testing for Windows, but we also aren't releasing Windows builds at the moment either.I'll make sure we have an issue open for Windows testing / releases, but I'm inclined to get this merged without that and hopefully prioritize that soon.
Closes #280