[pull] latest from npm:latest #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- What / Why --> This solves problem described in #8335 in a backwards-compatible way. <!-- Describe the request in detail. What it does and why it's being changed. --> This PR adds possibility to have env var replacements in .npmrc configs written as `${VAR?}` which will cause them to get replaced with an empty string if the variable is not defined. Old behavior where undefined variables are left unreplaced is not changed. ## References <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Fixes #8335 --------- Co-authored-by: Michael Smith <[email protected]>
While investigating CI failure in #8537, I found unrelated test failures when running locally on windows. `prune with lockfile with implicit optional peer dependencies` fixed by adding files to fixture `node_modules`, avoiding network, also reduced package lock to minimum and removed unhelpful snapshots `move aside symlink clutter` fixed by creating problematic symlink in `t.testdir()` instead of in `reifyPackages` hook --------- Co-authored-by: Liam Mitchell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )