Upgrade jest #100
Merged
Upgrade jest #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sdunster
commented
Dec 3, 2017
sdunster
commented
- Beta version because it has a bug fix for testing rejected promises:
- fix .toThrow for promises jestjs/jest#4884
- Needed for upcoming unit tests for events/schedules API
* Beta version because it has a bug fix for testing rejected promises: * jestjs/jest#4884 * Needed for upcoming unit tests for events/schedules API
cmiceli
approved these changes
Dec 3, 2017
Contributor
cmiceli
left a comment
cmiceli
left a comment
There was a problem hiding this comment.
Accepting to unbreak work, but it seems shitty to use beta level software if we can avoid.
Member
Author
|
@cmiceli FYI the whole of react native is beta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.