fix(runnable-rails): preserve message metadata in RunnableRails tool calling #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgasser-nv
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Looks good. The only issue I can see is that Langchain doesn't support OpenAI's new developer role. We can handle this by treating developer turns the same as system ones (that they're replacing).
Some other nits to address before merging.
Pouyanpi
force-pushed
the
feat/tool-calling-input
branch
from
c8ff064 to
5792bea
Compare
- Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
Pouyanpi
force-pushed
the
fix/message-metadata-lc
branch
from
7b6b0ba to
5a33601
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
tgasser-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
tgasser-nv
pushed a commit
that referenced
this pull request
Sep 22, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
Pouyanpi
added a commit
that referenced
this pull request
Oct 1, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
…calling (#1405) * fix: preserve message metadata in RunnableRails tool calling - Extract message conversion logic to centralized message_utils module - Dynamically preserve all LangChain message fields (tool_calls, additional_kwargs, etc.) - Fix tool calling metadata loss in passthrough mode - Add comprehensive unit tests for message conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Changes
message_utils.pywith centralized message conversion functions