Skip to content

Conversation

Funatiq
Copy link
Collaborator

@Funatiq Funatiq commented Apr 28, 2025

Description

  • Introduced a new document detailing the hierarchy and event system for KV cache management, including definitions for Pool, Block, and Page.
  • Updated the index.rst to include a reference to the new kv-cache-management.md file.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Funatiq and others added 3 commits April 29, 2025 07:06
* Introduced a new document detailing the hierarchy and event system for KV cache management, including definitions for Pool, Block, and Page.
* Updated the index.rst to include a reference to the new kv-cache-management.md file.

Signed-off-by: Robin Kobus <[email protected]>
Co-authored-by: Netanel Haber <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
@Funatiq Funatiq marked this pull request as ready for review April 29, 2025 07:09
@Funatiq Funatiq changed the title feat: Add KV Cache Management documentation docs: Add KV Cache Management documentation May 2, 2025
Funatiq added 3 commits May 14, 2025 10:13
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
@Funatiq Funatiq changed the base branch from main to release/0.20 May 20, 2025 08:15
@Funatiq Funatiq requested a review from a team as a code owner May 20, 2025 08:15
@Funatiq
Copy link
Collaborator Author

Funatiq commented May 20, 2025

/bot skip --comment "Doc update only"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5851 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5851 [ skip ] completed with state SUCCESS
Skipping testing for commit 001e4dc

@litaotju
Copy link
Collaborator

Thx for the clear and great document @Funatiq !!

@Funatiq Funatiq merged commit cc490de into NVIDIA:release/0.20 May 21, 2025
3 checks passed
@Funatiq Funatiq deleted the dev/doc_kv_cache branch May 21, 2025 14:26
amirkl94 pushed a commit to amirkl94/TensorRT-LLM that referenced this pull request May 27, 2025
* docs: Add KV Cache Management documentation

* Introduced a new document detailing the hierarchy and event system for KV cache management, including definitions for Pool, Block, and Page.
* Updated the index.rst to include a reference to the new kv-cache-management.md file.

Signed-off-by: Robin Kobus <[email protected]>

* Update docs/source/advanced/kv-cache-management.md

Co-authored-by: Netanel Haber <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>

* Update KV Cache Pool Management

Signed-off-by: Robin Kobus <[email protected]>

* docs: Addcross-file links

Signed-off-by: Robin Kobus <[email protected]>

* docs: Clarify tokens_per_block

Signed-off-by: Robin Kobus <[email protected]>

* docs: Clarify acronyms

Signed-off-by: Robin Kobus <[email protected]>

---------

Signed-off-by: Robin Kobus <[email protected]>
Co-authored-by: Netanel Haber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants