Skip to content

Conversation

@venkywonka
Copy link
Collaborator

@venkywonka venkywonka commented May 5, 2025

PR title

Set trust_remote_code=True when verifying config.json load.
When this isn't set, the behavior defaults to the model-config-specific from_hugging_face implementation's default trust_remote_code value.
For models like LlamaConfig, their internal usage default to trust_remote_code=True unless specified - but others like DeciLMConfig deafults to trust_remote_code=False. When its False, it raises an error when loading from huggingface.

Test Coverage

There is a unittest that hits that code-path (tests/unittest/llmapi/test_llm_utils.py#L15-L36), but it uses TinyLlama hence passes.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@venkywonka venkywonka requested review from Copilot and kaiyux May 5, 2025 18:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes model configuration loading by setting trust_remote_code=True in the call to AutoConfig.from_hugging_face, ensuring consistent behavior when loading config.json.

  • Adjusted AutoConfig.from_hugging_face call in the HF branch
  • Aims to prevent errors for models like DeciLMConfig when trust_remote_code is False

@venkywonka venkywonka requested a review from schetlur-nv May 5, 2025 18:42
@venkywonka venkywonka marked this pull request as ready for review May 5, 2025 18:45
@FrankD412 FrankD412 self-requested a review May 5, 2025 18:46
Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Superjomn Superjomn enabled auto-merge (squash) May 5, 2025 23:25
auto-merge was automatically disabled May 6, 2025 13:40

Head branch was pushed to by a user without write access

@venkywonka venkywonka force-pushed the user/venky/fix-bench-hf-config-load branch from 46d0fab to d537643 Compare May 6, 2025 13:40
@venkywonka
Copy link
Collaborator Author

closing this, as this is model-specific, and included in #4128

@venkywonka venkywonka closed this May 7, 2025
@venkywonka venkywonka deleted the user/venky/fix-bench-hf-config-load branch May 8, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants