[TRTLLM-5171] chore: Remove GptSession/V1 from TRT workflow #4092
Conversation
|
/bot run |
|
PR_Github #4228 [ run ] triggered by Bot |
|
PR_Github #4228 [ run ] completed with state |
|
/bot run |
|
PR_Github #4241 [ run ] triggered by Bot |
|
PR_Github #4241 [ run ] completed with state |
|
/bot run --stage-list "H100_PCIe-CPP-1" |
|
PR_Github #4259 [ run ] triggered by Bot |
|
PR_Github #4259 [ run ] completed with state |
Funatiq
force-pushed
the
dev/remove_gpt_session
branch
from
8e1f7e9 to
afa60f1
Compare
|
/bot run --stage-list "H100_PCIe-CPP-1" |
|
PR_Github #4352 [ run ] triggered by Bot |
|
PR_Github #4352 [ run ] completed with state |
There was a problem hiding this comment.
Looks good overall. Two small comments / questions:
- Are we confident that we are not losing too much incidental testing by removing the
gptSessiontests? - I've encountered many symbols only referenced in the
gptSessionpath. Are you sure you removed all of those, as they should be now unused.
|
LGTM. Nice. Julien's questions are good ones, though. |
Funatiq
changed the title
Funatiq
force-pushed
the
dev/remove_gpt_session
branch
from
3853388 to
71b4561
Compare
|
/bot run |
|
PR_Github #4869 [ run ] triggered by Bot |
|
PR_Github #4869 [ run ] completed with state |
Funatiq
force-pushed
the
dev/remove_gpt_session
branch
from
28392c0 to
1703a10
Compare
|
/bot run |
|
PR_Github #4906 [ run ] triggered by Bot |
|
PR_Github #4906 [ run ] completed with state |
|
/bot run |
|
PR_Github #5001 [ run ] triggered by Bot |
|
PR_Github #5001 [ run ] completed with state |
|
PR_Github #5020 [ run ] triggered by Bot |
|
PR_Github #5020 [ run ] completed with state |
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Robin Kobus <[email protected]>
- Updated `validateContextLogits` and `validateGenerationLogits` functions to remove the `batchingType` parameter. - Adjusted related test functions to reflect the changes in parameter lists. - Cleaned up the instantiation of test cases to eliminate unnecessary batchingType references. Signed-off-by: Robin Kobus <[email protected]>
Funatiq
force-pushed
the
dev/remove_gpt_session
branch
from
ff477bb to
a79f641
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #5044 [ run ] triggered by Bot |
Yes, the models are also covered in
I cleaned up everything I could find. |
|
PR_Github #5044 [ run ] completed with state |
|
/bot run |
|
PR_Github #5149 [ run ] triggered by Bot |
|
PR_Github #5149 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #5193 [ run ] triggered by Bot |
|
PR_Github #5193 [ run ] completed with state |
Description
Please explain the issue and the solution in short.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.