Skip to content

Conversation

DomBrown
Copy link
Collaborator

PR title

Test: Improve model re-use in C++ DGX tests for CI stability

Description

We continue to observe poor throughput of the DGX tests in CI.
This PR aims to speed up the C++ DGX tests stage slightly by reusing already built model engines and expected outputs, where possible.

Some test cases have also been further split to improve granularity and reporting.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@DomBrown DomBrown self-assigned this May 13, 2025
@DomBrown DomBrown added the Infra <NV>automated tests, build checks, github actions, system stability & efficiency. label May 13, 2025
@DomBrown
Copy link
Collaborator Author

/bot run --stage-list "DGX_H100-4_GPUs-CPP-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5005 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5005 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3638 (Partly Tested) completed with status: 'FAILURE'

@DomBrown
Copy link
Collaborator Author

/bot run --stage-list "DGX_H100-4_GPUs-CPP-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5008 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5008 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3641 (Partly Tested) completed with status: 'SUCCESS'

@DomBrown
Copy link
Collaborator Author

Model re-use seems to knock ~10 minutes off of the pipeline (DGX C++)

@DomBrown DomBrown force-pushed the domb/cpp_test_model_reuse branch from e7f7d6e to 2f0a541 Compare May 15, 2025 15:57
@DomBrown DomBrown requested review from hypdeb and Funatiq May 15, 2025 15:58
@DomBrown
Copy link
Collaborator Author

/bot run --stage-list "DGX_H100-4_GPUs-CPP-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5371 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5371 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3920 (Partly Tested) completed with status: 'SUCCESS'

@DomBrown
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5397 [ run ] triggered by Bot

@DomBrown DomBrown marked this pull request as ready for review May 15, 2025 21:30
@tensorrt-cicd
Copy link
Collaborator

PR_Github #5397 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3939 completed with status: 'FAILURE'

@DomBrown DomBrown requested a review from Funatiq May 16, 2025 14:37
@DomBrown DomBrown force-pushed the domb/cpp_test_model_reuse branch from 4f57932 to 00c04d1 Compare May 16, 2025 15:44
@DomBrown
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5526 [ run ] triggered by Bot

DomBrown added 6 commits May 18, 2025 09:54
Signed-off-by: Dom Brown <[email protected]>
Signed-off-by: Dom Brown <[email protected]>
Signed-off-by: Dom Brown <[email protected]>
Signed-off-by: Dom Brown <[email protected]>
@DomBrown DomBrown force-pushed the domb/cpp_test_model_reuse branch from 00c04d1 to e4998ee Compare May 18, 2025 08:54
@DomBrown
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5607 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5607 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4092 completed with status: 'FAILURE'

@DomBrown
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5621 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #5621 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4106 completed with status: 'SUCCESS'

@DomBrown DomBrown merged commit c45f414 into NVIDIA:main May 19, 2025
3 checks passed
@DomBrown DomBrown deleted the domb/cpp_test_model_reuse branch May 19, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infra <NV>automated tests, build checks, github actions, system stability & efficiency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants