Skip to content

Conversation

@ruodil
Copy link
Collaborator

@ruodil ruodil commented May 14, 2025

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ruodil ruodil requested review from LarryXFly and venkywonka May 14, 2025 08:28
@venkywonka
Copy link
Collaborator

venkywonka commented May 14, 2025

Can we have the PR description say something about the tests added? better if we could just publish the numbers (like #4128 and #4267) so we know they pass without hangs/failures, in appropriate timeout settings, with throughput numbers that make sense.

That would enable us to flag some failing/hanging tests at the early stages itself (and create bug tickets for them) rather than merging this into main and then facing problems later
cc @tijyojwad @schetlur-nv @LarryXFly @kaiyux

Thanks!

@ruodil
Copy link
Collaborator Author

ruodil commented May 21, 2025

Can we have the PR description say something about the tests added? better if we could just publish the numbers (like #4128 and #4267) so we know they pass without hangs/failures, in appropriate timeout settings, with throughput numbers that make sense.

That would enable us to flag some failing/hanging tests at the early stages itself (and create bug tickets for them) rather than merging this into main and then facing problems later cc @tijyojwad @schetlur-nv @LarryXFly @kaiyux

Thanks!

that's a good advice, I'll test on my local branch and see whether these cases can pass.

@ruodil ruodil force-pushed the user/ruodil/case_add branch 4 times, most recently from 89cb571 to fe9e759 Compare May 29, 2025 02:51
@ruodil ruodil force-pushed the user/ruodil/case_add branch 2 times, most recently from b562614 to f34fc37 Compare June 3, 2025 08:13
@ruodil ruodil closed this Jun 9, 2025
@ruodil
Copy link
Collaborator Author

ruodil commented Jun 9, 2025

closing this pr due to oom issue on H100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants