-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: skip weights defined in create_weights for pp. #4447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yuxian Qiu <[email protected]>
/bot run --disable-fail-fast --add-multi-gpu-test |
PR_Github #5739 [ run ] triggered by Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Local tests passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does any CI test fail before this change?
PR_Github #5739 [ run ] completed with state |
@amukkara No, @Barry-Delaney get OOM issue when running |
/bot run --disable-fail-fast --add-multi-gpu-test |
PR_Github #5812 [ run ] triggered by Bot |
PR_Github #5812 [ run ] completed with state |
/bot run --disable-fail-fast --add-multi-gpu-test |
PR_Github #5871 [ run ] triggered by Bot |
PR_Github #5871 [ run ] completed with state |
Signed-off-by: Yuxian Qiu <[email protected]>
fix: skip weights defined in create_weights for pp. (#4447) Signed-off-by: Yuxian Qiu <[email protected]>
Since
DecoderModel
's__pp_init__
is called beforeDecoderModelForCausalLM
's__post_init__
, it fails to skip weights for those weights defined increate_weights
, which is created inside__post_init__
.We call
DecoderModel
's__pp_init__
insideDecoderModelForCausalLM
's__pp_init__
to fix it, sinceDecoderModelForCausalLM
's__pp_init__
is called after its__post_init__
.