Skip to content

feat: Skip sampler for intermediate pp stages. #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 26, 2025
Merged

feat: Skip sampler for intermediate pp stages. #4514

merged 8 commits into from
May 26, 2025

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented May 21, 2025

No description provided.

yuxianq
yuxianq commented May 21, 2025
View reviewed changes
yuxianq
yuxianq commented May 21, 2025
View reviewed changes
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 21, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 21, 2025

PR_Github #5947 [ run ] triggered by Bot

@yuxianq
Address comment.
6bdecbb 
Signed-off-by: Yuxian Qiu <[email protected]>
yuxianq
yuxianq commented May 21, 2025
View reviewed changes
@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 21, 2025

PR_Github #5947 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4353 completed with status: 'FAILURE'

amukkara
amukkara approved these changes May 21, 2025
View reviewed changes
@yuxianq
Address comment.
dc075be 
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq yuxianq requested a review from a team as a code owner May 22, 2025 03:39
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 22, 2025

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 22, 2025

PR_Github #6092 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 22, 2025

PR_Github #6092 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4452 completed with status: 'FAILURE'

@yuxianq
Fix CI error.
5d703fc 
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 23, 2025

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6231 [ run ] triggered by Bot

@yuxianq
Fix CI error.
d653814 
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 23, 2025

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6237 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6231 [ run ] completed with state ABORTED

@yuxianq
Fix rebase error.
7d8acd2 
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 23, 2025

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6245 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6237 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6245 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4563 (Partly Tested) completed with status: 'FAILURE'

@yuxianq
Fix CI error.
783bcb0 
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq yuxianq requested a review from a team as a code owner May 23, 2025 15:52
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 23, 2025

/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6317 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6317 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4615 (Partly Tested) completed with status: 'FAILURE'

@yuxianq yuxianq enabled auto-merge (squash) May 23, 2025 20:19
@yuxianq
Copy link
Collaborator Author

yuxianq commented May 23, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 23, 2025

PR_Github #6331 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 24, 2025

PR_Github #6331 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4621 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented May 24, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 24, 2025

PR_Github #6348 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 24, 2025

PR_Github #6348 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4635 completed with status: 'FAILURE'

@yuxianq
Copy link
Collaborator Author

yuxianq commented May 25, 2025

/bot skip --comment "The failed test unittest/llmapi/test_llm_multi_gpu.py::test_llm_multi_node_with_postproc is unrelated to this PR and caused by #3869, all of other tests have been passed."

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 25, 2025

PR_Github #6384 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented May 25, 2025

PR_Github #6384 [ skip ] completed with state SUCCESS
Skipping testing for commit 3d11f32

@yuxianq yuxianq requested a review from litaotju May 26, 2025 02:03
@yuxianq yuxianq merged commit 8f055f5 into NVIDIA:main May 26, 2025
3 checks passed
Shang-Pin pushed a commit to deepinfra/TensorRT-LLM that referenced this pull request May 27, 2025
@yuxianq
feat: Skip sampler for intermediate pp stages. (NVIDIA#4514)
189325e 
Signed-off-by: Yuxian Qiu <[email protected]>
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
@yuxianq @darraghdog
feat: Skip sampler for intermediate pp stages. (NVIDIA#4514)
124df0d 
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: darraghdog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@litaotju litaotju litaotju approved these changes

@amukkara amukkara amukkara approved these changes

@yizhang-nv yizhang-nv yizhang-nv approved these changes

@tongyuantongyu tongyuantongyu Awaiting requested review from tongyuantongyu

@symphonylyh symphonylyh Awaiting requested review from symphonylyh

@juney-nvidia juney-nvidia Awaiting requested review from juney-nvidia juney-nvidia is a code owner automatically assigned from NVIDIA/trt-llm-torch-devs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yuxianq @tensorrt-cicd @litaotju @tongyuantongyu @amukkara @yizhang-nv