fix: max_num_sequences calculation with overlap scheduling #4532
Conversation
|
/bot run |
|
PR_Github #6003 [ run ] triggered by Bot |
|
PR_Github #6003 [ run ] completed with state |
|
/bot run |
|
PR_Github #6029 [ run ] triggered by Bot |
|
PR_Github #6029 [ run ] completed with state |
dcampora
force-pushed
the
dev/fix_num_slots
branch
from
3243755 to
1a188d1
Compare
|
/bot run |
|
PR_Github #6128 [ run ] triggered by Bot |
|
PR_Github #6128 [ run ] completed with state |
|
/bot run |
|
PR_Github #6140 [ run ] triggered by Bot |
|
PR_Github #6140 [ run ] completed with state |
Funatiq
force-pushed
the
dev/fix_num_slots
branch
from
a38abe8 to
b55175b
Compare
|
/bot run |
|
PR_Github #6179 [ run ] triggered by Bot |
|
PR_Github #6179 [ run ] completed with state |
Funatiq
force-pushed
the
dev/fix_num_slots
branch
from
b55175b to
e644506
Compare
|
/bot run |
|
/bot run |
|
PR_Github #6503 [ run ] triggered by Bot |
|
PR_Github #6503 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #6610 [ run ] triggered by Bot |
|
PR_Github #6610 [ run ] completed with state |
Funatiq
force-pushed
the
dev/fix_num_slots
branch
from
e644506 to
aac3b7f
Compare
|
/bot run |
|
PR_Github #6788 [ run ] triggered by Bot |
|
PR_Github #6788 [ run ] completed with state |
|
/bot run |
|
PR_Github #6901 [ run ] triggered by Bot |
|
PR_Github #6901 [ run ] completed with state |
|
/bot run |
- `max_num_sequences` is now calculated as `max_batch_size * pp_size`. - In overlap scheduling, `max_num_sequences` is `max_batch_size` although there are two micro batches in flight. - Updated the `CapacityScheduler` and `MaxUtilizationScheduler` classes to replace the `manyMicroBatches` parameter with `twoStepsLookAhead` for clarity. - Adjusted related implementations and initializations across the codebase to reflect this change, ensuring consistent usage in the scheduling logic. Signed-off-by: Robin Kobus <[email protected]>
Signed-off-by: Daniel Campora <[email protected]>
dcampora
force-pushed
the
dev/fix_num_slots
branch
from
5db0c30 to
64edc79
Compare
|
/bot run |
|
PR_Github #7019 [ run ] triggered by Bot |
|
PR_Github #7019 [ run ] completed with state |
Signed-off-by: Robin Kobus <[email protected]>
|
/bot run |
|
PR_Github #7217 [ run ] triggered by Bot |
|
PR_Github #7217 [ run ] completed with state |
Signed-off-by: Robin Kobus <[email protected]> Signed-off-by: Daniel Campora <[email protected]> Co-authored-by: Daniel Campora <[email protected]> Signed-off-by: darraghdog <[email protected]>
Signed-off-by: Robin Kobus <[email protected]> Signed-off-by: Daniel Campora <[email protected]> Co-authored-by: Daniel Campora <[email protected]>
Description
max_num_sequencesis now calculated asmax_batch_size * pp_size.max_num_sequencesismax_batch_sizealthough there are two micro batches in flight.CapacitySchedulerandMaxUtilizationSchedulerclasses to replace themanyMicroBatchesparameter withtwoStepsLookAheadfor clarity.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.