Skip to content

Conversation

LinPoly
Copy link
Collaborator

@LinPoly LinPoly commented May 22, 2025

Description

Download sharegpt if it is not stored locally, this can slightly improve usability.

Test Coverage

New tests maybe needed but currently we don't have tests for benchmark_serving, this can be future work.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@LinPoly LinPoly requested review from kaiyux and jiahanc May 22, 2025 13:39
@LinPoly LinPoly force-pushed the user/pengyunl/enhance_bench_serving branch from 3fd8fa2 to bcf7cd0 Compare May 23, 2025 12:15
@LinPoly
Copy link
Collaborator Author

LinPoly commented May 23, 2025

Tested locally and works fine.

@LinPoly LinPoly changed the title draft: [feat] support sharegpt downloading in benchmark_serving [feat] support sharegpt downloading in benchmark_serving May 23, 2025
@LinPoly
Copy link
Collaborator Author

LinPoly commented May 23, 2025

Shall we merge this after tests added to CI or verifying locally is just enough for now? @kaiyux @jiahanc

@kaiyux
Copy link
Member

kaiyux commented May 27, 2025

/bot skip --comment "script is not covered by pipeline yet"

@kaiyux kaiyux enabled auto-merge (squash) May 27, 2025 12:52
@tensorrt-cicd
Copy link
Collaborator

PR_Github #6645 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6645 [ skip ] completed with state SUCCESS
Release Check Pipeline #1012 failed

@LinPoly LinPoly force-pushed the user/pengyunl/enhance_bench_serving branch from bcf7cd0 to 50583a6 Compare May 29, 2025 05:01
@LinPoly
Copy link
Collaborator Author

LinPoly commented May 29, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6878 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6878 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #4998 completed with status: 'FAILURE'

Signed-off-by: Pengyun Lin <[email protected]>
@LinPoly
Copy link
Collaborator Author

LinPoly commented May 29, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6909 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6909 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5014 completed with status: 'FAILURE'

@kaiyux
Copy link
Member

kaiyux commented May 30, 2025

/bot skip --comment "script is not covered by pipeline yet"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7062 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7062 [ skip ] completed with state SUCCESS
Skipping testing for commit e85f2de

@kaiyux kaiyux merged commit bac22ff into NVIDIA:main May 30, 2025
3 checks passed
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants