[nvbugs/5274894] fix: Sort requests for functional correctness and performance (adapted from #4608) #4621
Conversation
|
/bot run |
|
PR_Github #6307 [ run ] triggered by Bot |
|
PR_Github #6307 [ run ] completed with state |
Funatiq
force-pushed
the
dev/fix_moving_chunked_main
branch
from
dcf2e35 to
ce3b905
Compare
|
/bot run |
|
PR_Github #6324 [ run ] triggered by Bot |
|
PR_Github #6324 [ run ] completed with state |
|
/bot run |
|
PR_Github #6330 [ run ] triggered by Bot |
Funatiq
force-pushed
the
dev/fix_moving_chunked_main
branch
from
d5f9532 to
10b250e
Compare
|
/bot run |
|
PR_Github #6332 [ run ] triggered by Bot |
|
PR_Github #6330 [ run ] completed with state |
|
PR_Github #6332 [ run ] completed with state |
|
/bot run |
|
PR_Github #6363 [ run ] triggered by Bot |
|
PR_Github #6363 [ run ] completed with state |
…rformance (adapted from NVIDIA#4608) - Moved sorting related logic to a dedicated function for better clarity and maintainability. - Enhanced sorting logic to separate finished context requests from ongoing ones before sorting by Lora task ID. - Updated function documentation to reflect the sorting behavior and its purpose. Signed-off-by: Robin Kobus <[email protected]>
… and performance (adapted from NVIDIA#4608) Signed-off-by: Robin Kobus <[email protected]>
Funatiq
force-pushed
the
dev/fix_moving_chunked_main
branch
from
10b250e to
ce6aba3
Compare
|
/bot run |
|
PR_Github #6431 [ run ] triggered by Bot |
|
PR_Github #6431 [ run ] completed with state |
…rformance (adapted from NVIDIA#4608) (NVIDIA#4621) - Moved sorting related logic to a dedicated function for better clarity and maintainability. - Enhanced sorting logic to separate finished context requests from ongoing ones before sorting by Lora task ID. - Updated function documentation to reflect the sorting behavior and its purpose. Signed-off-by: Robin Kobus <[email protected]>
…rformance (adapted from NVIDIA#4608) (NVIDIA#4621) - Moved sorting related logic to a dedicated function for better clarity and maintainability. - Enhanced sorting logic to separate finished context requests from ongoing ones before sorting by Lora task ID. - Updated function documentation to reflect the sorting behavior and its purpose. Signed-off-by: Robin Kobus <[email protected]> Signed-off-by: darraghdog <[email protected]>
3 participants
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.