-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[TRTLLM-4971]: Use safe deserialization in ParallelConfig #4630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRTLLM-4971]: Use safe deserialization in ParallelConfig #4630
Conversation
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #6334 [ run ] triggered by Bot |
PR_Github #6334 [ run ] completed with state |
7e2e768
to
deaac01
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #6350 [ run ] triggered by Bot |
PR_Github #6350 [ run ] completed with state |
deaac01
to
e0bf861
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #6397 [ run ] triggered by Bot |
PR_Github #6397 [ run ] completed with state |
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #6501 [ run ] triggered by Bot |
PR_Github #6501 [ run ] completed with state |
@kaiyux Who do you think would be the best reviewer for this PR? I checked contribution history to ParallelConfig and your name pops up :) |
@yuxianq Since it's related to auto parallel, can you help take a look? |
e0bf861
to
6aaf52b
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #7243 [ run ] triggered by Bot |
PR_Github #7243 [ run ] completed with state |
6aaf52b
to
6fad474
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #8981 [ run ] triggered by Bot |
PR_Github #8981 [ run ] completed with state |
2f1ab6b
to
e522c01
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #9043 [ run ] triggered by Bot |
PR_Github #9043 [ run ] completed with state |
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
e522c01
to
d0caf72
Compare
/bot run --add-multi-gpu-test --disable-fail-fast |
PR_Github #9224 [ run ] triggered by Bot |
/bot kill |
PR_Github #9258 [ kill ] triggered by Bot |
PR_Github #9258 [ kill ] completed with state |
/bot run --add-multi-gpu-test |
PR_Github #9261 [ run ] triggered by Bot |
PR_Github #9261 [ run ] completed with state |
@kaiyux @Superjomn This MR relocates |
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Signed-off-by: Yibin Li <[email protected]>
Use safe deserialization in ParallelConfig
Description
Remove unsafe pickle.load usage in ParallelConfig by using a safe deserialization method. During the tests, I realized that the current location of
serialization.py
under executor directory will cause a circular import of the files that importParallelConfig
, so I move theserialization.py
outside of executor directory.Test Coverage
Added a new test
test_parallel_config_serialization
to check the correctness of safe serialization / deserialization ofParallelConfig
.