Skip to content

Update the description for NGC docker images #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Update the description for NGC docker images #4671

merged 1 commit into from
May 27, 2025

Conversation

MartinMarciniszyn
Copy link
Collaborator

Update the descriptions for docker images

This PR adds docker/develop.md and docker/release.md which describe the usage of the docker published to NGC. We also make some minor fixes in docker/Makefile.

@MartinMarciniszyn MartinMarciniszyn self-assigned this May 26, 2025
@MartinMarciniszyn MartinMarciniszyn requested review from a team as code owners May 26, 2025 16:38
@MartinMarciniszyn MartinMarciniszyn changed the base branch from main to release/0.20 May 26, 2025 16:38
@MartinMarciniszyn MartinMarciniszyn requested a review from a team as a code owner May 26, 2025 16:38
@MartinMarciniszyn
Copy link
Collaborator Author

/bot run --skip-tests

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6495 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: --skip-tests

@MartinMarciniszyn
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6496 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6496 [ run ] completed with state SUCCESS
/LLM/release-0.20/L0_MergeRequest_PR pipeline #73 (Partly Tested) completed with status: 'SUCCESS'

@kaiyux
Copy link
Member

kaiyux commented May 27, 2025

/bot skip --comment "Sanity check passed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6520 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6520 [ skip ] completed with state SUCCESS
Skipping testing for commit a868049

@kaiyux kaiyux merged commit 8eafe83 into NVIDIA:release/0.20 May 27, 2025
2 checks passed
@MartinMarciniszyn MartinMarciniszyn deleted the user/martinma/describe_ngc_images branch May 27, 2025 16:15
MartinMarciniszyn added a commit to MartinMarciniszyn/TensorRT-LLM that referenced this pull request May 27, 2025
@MartinMarciniszyn
Update the description for NGC docker images (NVIDIA#4671)
4c43c01 
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
@MartinMarciniszyn MartinMarciniszyn mentioned this pull request May 27, 2025
Merged
kaiyux pushed a commit that referenced this pull request May 27, 2025
@MartinMarciniszyn
Update the description for NGC docker images (#4671) (#4702)
06eba1e 
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
@MartinMarciniszyn @darraghdog
Update the description for NGC docker images (NVIDIA#4671) (NVIDIA#4702)
e7628de 
Signed-off-by: Martin Marciniszyn Mehringer <[email protected]>
Signed-off-by: darraghdog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyux kaiyux kaiyux approved these changes

@Shixiaowei02 Shixiaowei02 Awaiting requested review from Shixiaowei02

Assignees

@MartinMarciniszyn MartinMarciniszyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinMarciniszyn @tensorrt-cicd @kaiyux