Skip to content

Conversation

farazkh80
Copy link
Collaborator

@farazkh80 farazkh80 commented May 27, 2025

Description

For SM120 and SM121, we need to take the JIT path for XQA. In order to avoid accuracy issues, we do virtual PTX compilation for SM 89 and then PTX to CUBIN for SM120.

Test Coverage

  • perf/test_perf.py::test_perf[llama_v3.1_70b-bench-pytorch-bfloat16-input_output_len:128,128-tp:2-gpus:2]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@farazkh80
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6521 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6521 [ run ] completed with state FAILURE
/LLM/release-0.20/L0_MergeRequest_PR pipeline #77 completed with status: 'FAILURE'

@juney-nvidia
Copy link
Collaborator

juney-nvidia commented May 27, 2025

@farazkh80 Hi , do we on purpose want to target this PR to the 0.20 release branch?

Thanks
June

@farazkh80
Copy link
Collaborator Author

@juney-nvidia Hey, this is a fix for https://nvbugspro.nvidia.com/bug/5291971 that we need for 0.20 release

@farazkh80
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6657 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6657 [ run ] completed with state FAILURE
/LLM/release-0.20/L0_MergeRequest_PR pipeline #88 completed with status: 'FAILURE'

@farazkh80
Copy link
Collaborator Author

/bot run --disable-fail-fast

1 similar comment
@farazkh80
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6988 [ run ] triggered by Bot

@farazkh80
Copy link
Collaborator Author

/bot run --disable-fail-fast

@farazkh80 farazkh80 marked this pull request as ready for review May 30, 2025 02:13
@farazkh80 farazkh80 requested a review from a team as a code owner May 30, 2025 02:13
@tensorrt-cicd
Copy link
Collaborator

PR_Github #6989 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6988 [ run ] completed with state ABORTED

@farazkh80 farazkh80 force-pushed the b40-0.20-fix-jit-attention branch 2 times, most recently from b50e391 to 8d68bc2 Compare May 30, 2025 15:13
@NVIDIA NVIDIA deleted a comment from tensorrt-cicd May 30, 2025
@NVIDIA NVIDIA deleted a comment from tensorrt-cicd May 30, 2025
@NVIDIA NVIDIA deleted a comment from tensorrt-cicd May 30, 2025
@farazkh80
Copy link
Collaborator Author

/bot run --disable-fail-fast

@farazkh80 farazkh80 changed the title JIT path for XQA [NVBUG-5291971] JIT path for XQA May 30, 2025
@farazkh80 farazkh80 force-pushed the b40-0.20-fix-jit-attention branch 2 times, most recently from c88a59e to d5544a4 Compare May 30, 2025 16:36
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7092 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7097 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7092 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7098 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7097 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7098 [ run ] completed with state SUCCESS
/LLM/release-0.20/L0_MergeRequest_PR pipeline #144 completed with status: 'SUCCESS'

@farazkh80 farazkh80 enabled auto-merge (squash) May 30, 2025 23:44
@farazkh80 farazkh80 merged commit 10d5af0 into NVIDIA:release/0.20 Jun 2, 2025
3 checks passed
omera-nv pushed a commit to omera-nv/TensorRT-LLM that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants