Skip to content

Conversation

@hlu1
Copy link
Collaborator

@hlu1 hlu1 commented May 28, 2025

Description

Redesign the Linear module.

  • Separate out and encapsulate the quantization related logics into individual LinearMethod class for each quant_config.
  • Create separate weight loading functions for the different weight_modes.
  • I believe the code is much easier to follow after the refactor.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@hlu1 hlu1 requested review from HuiGao-NV, QiJune and yuxianq May 28, 2025 06:10
@hlu1 hlu1 requested a review from a team as a code owner May 28, 2025 06:10
@hlu1 hlu1 requested a review from Tracin May 28, 2025 06:13
@hlu1
Copy link
Collaborator Author

hlu1 commented May 28, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6715 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6715 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4903 completed with status: 'FAILURE'

@hlu1
Copy link
Collaborator Author

hlu1 commented May 28, 2025

/bot run --disable-fail-fast

1 similar comment
@hlu1
Copy link
Collaborator Author

hlu1 commented May 29, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6823 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6823 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4969 completed with status: 'FAILURE'

@hlu1
Copy link
Collaborator Author

hlu1 commented May 29, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6887 [ run ] triggered by Bot

Copy link
Collaborator

@yuxianq yuxianq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6887 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5003 completed with status: 'FAILURE'

@hlu1
Copy link
Collaborator Author

hlu1 commented May 29, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6952 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6952 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5047 completed with status: 'SUCCESS'

Signed-off-by: Hao Lu <[email protected]@users.noreply.github.com>
@hlu1
Copy link
Collaborator Author

hlu1 commented May 29, 2025

/bot skip --comment "Reuse previous successful pipeline"

@hlu1 hlu1 merged commit 3093c74 into NVIDIA:main May 29, 2025
2 of 3 checks passed
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
Signed-off-by: Hao Lu <[email protected]@users.noreply.github.com>
Co-authored-by: Hao Lu <[email protected]@users.noreply.github.com>
Signed-off-by: darraghdog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants