Skip to content

Conversation

syuoni
Copy link
Collaborator

@syuoni syuoni commented May 29, 2025

fix: EP load balancer with MTP layer and route offset by EP rank

Description

This PR fixes:

  • EP load balancer with MTP layer

Also, it enables

  • Offset round robin position by EP rank for attention DP in fused MoE

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@syuoni syuoni requested review from wm2012011492 and dongxuy04 May 29, 2025 13:04
@syuoni syuoni self-assigned this May 29, 2025
@syuoni
Copy link
Collaborator Author

syuoni commented May 29, 2025

/bot run

@syuoni syuoni marked this pull request as ready for review May 29, 2025 13:05
@syuoni syuoni requested a review from a team as a code owner May 29, 2025 13:05
@syuoni syuoni requested a review from yilin-void May 29, 2025 13:05
@syuoni
Copy link
Collaborator Author

syuoni commented May 29, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6935 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6935 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5035 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented May 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6975 [ run ] triggered by Bot

@syuoni syuoni changed the title fix: EP load balancer with MTP layer fix: EP load balancer with MTP layer and route offset by EP rank May 30, 2025
syuoni added 2 commits May 30, 2025 07:44
Signed-off-by: Enwei Zhu <[email protected]>
Signed-off-by: Enwei Zhu <[email protected]>
@syuoni syuoni force-pushed the fix-static-eplb branch from 09ffee5 to 2f130a5 Compare May 30, 2025 07:45
@syuoni
Copy link
Collaborator Author

syuoni commented May 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7047 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #6975 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7047 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5107 completed with status: 'FAILURE'

@syuoni
Copy link
Collaborator Author

syuoni commented May 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7110 [ run ] triggered by Bot

@syuoni
Copy link
Collaborator Author

syuoni commented May 31, 2025

/bot run --stage-list "DGX_H100-4_GPUs-CPP-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7139 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7110 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7139 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5159 (Partly Tested) completed with status: 'SUCCESS'

@syuoni
Copy link
Collaborator Author

syuoni commented May 31, 2025

/bot skip --comment "Combining last 3 pipelines, all stages passed"

@syuoni syuoni enabled auto-merge (squash) May 31, 2025 15:56
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7143 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7143 [ skip ] completed with state SUCCESS
Skipping testing for commit 2f130a5

@syuoni syuoni merged commit 25dde49 into NVIDIA:main May 31, 2025
3 checks passed
@syuoni syuoni deleted the fix-static-eplb branch May 31, 2025 16:10
@juney-nvidia juney-nvidia changed the title fix: EP load balancer with MTP layer and route offset by EP rank fix: large-scale EP - EP load balancer with MTP layer and route offset by EP rank Jun 1, 2025
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants