Skip to content

Conversation

hlu1
Copy link
Collaborator

@hlu1 hlu1 commented May 30, 2025

Description

Refactor FusedMoE

  • Move all moe related code to fused_moe/
  • Move all routing methods to routing.py. No other code change is made to routing.
  • Move all quant changes to quantization.py and apply the same refactoring strategy in linear.py
  • Separate out trtllm-gen code into class TRTLLMGenFusedMoE
  • More refactoring is necessary to separate the different forward paths in CutlassFuseMoE.
  • Remove the hack in FusedCutlass for MTP. There was a hack to force the MTP layer to use Cutlass backend when it's nvfp4 and moe_backend=="TRTLLM" and is_mtp. This is replaced with DeepseekV3DecoderLayer._get_decoder_layer_quant_config, which checks if the a particular decoder layer is excluded from quantization.

Test Coverage

Manual test

  • Deepseek min-latency benchmark

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@hlu1 hlu1 self-assigned this May 30, 2025
@hlu1 hlu1 requested a review from a team as a code owner May 30, 2025 05:00
@hlu1
Copy link
Collaborator Author

hlu1 commented May 30, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7023 [ run ] triggered by Bot

@hlu1 hlu1 requested review from dongfengy and a team May 30, 2025 05:18
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7023 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5096 completed with status: 'FAILURE'

@hlu1
Copy link
Collaborator Author

hlu1 commented May 31, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7113 [ run ] triggered by Bot

@hlu1
Copy link
Collaborator Author

hlu1 commented May 31, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7114 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7113 [ run ] completed with state ABORTED

@hlu1
Copy link
Collaborator Author

hlu1 commented May 31, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7120 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7114 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7120 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5145 completed with status: 'FAILURE'

@hlu1
Copy link
Collaborator Author

hlu1 commented Jun 2, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7186 [ run ] triggered by Bot

@hlu1
Copy link
Collaborator Author

hlu1 commented Jun 2, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7188 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7186 [ run ] completed with state ABORTED

@hlu1 hlu1 requested a review from dongxuy04 June 2, 2025 03:11
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7188 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5202 completed with status: 'FAILURE'

@hlu1 hlu1 requested a review from a team as a code owner June 2, 2025 21:44
@hlu1 hlu1 requested a review from i-riyad June 2, 2025 21:44
@hlu1
Copy link
Collaborator Author

hlu1 commented Jun 2, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7245 [ run ] triggered by Bot

@hlu1
Copy link
Collaborator Author

hlu1 commented Jun 2, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7247 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7245 [ run ] completed with state ABORTED

Copy link
Collaborator

@djns99 djns99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a massive usability improvement

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7247 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5249 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Signed-off-by: Hao Lu <[email protected]@users.noreply.github.com>
@hlu1
Copy link
Collaborator Author

hlu1 commented Jun 3, 2025

/bot skip --comment "Previous pipeline is successful"

@hlu1 hlu1 enabled auto-merge (squash) June 3, 2025 05:50
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7282 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7282 [ skip ] completed with state SUCCESS
Skipping testing for commit f4bade9

@hlu1 hlu1 merged commit 320195d into NVIDIA:main Jun 3, 2025
3 checks passed
darraghdog pushed a commit to darraghdog/TensorRT-LLM that referenced this pull request Jun 3, 2025
Signed-off-by: Hao Lu <[email protected]@users.noreply.github.com>
Co-authored-by: Hao Lu <[email protected]@users.noreply.github.com>
Signed-off-by: darraghdog <[email protected]>
@hlu1 hlu1 deleted the refactor branch June 19, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants