Skip to content

Conversation

moraxu
Copy link
Collaborator

@moraxu moraxu commented May 30, 2025

Description

Remove moe- related arguments from Llama-3_1-Nemotron-Ultra-253B-v1 CLI accuracy test

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@moraxu moraxu requested a review from a team as a code owner May 30, 2025 18:46
@moraxu moraxu requested a review from tijyojwad May 30, 2025 18:47
@moraxu
Copy link
Collaborator Author

moraxu commented May 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7102 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7102 [ run ] completed with state FAILURE
/LLM/release-0.20/L0_MergeRequest_PR pipeline #147 completed with status: 'FAILURE'

Signed-off-by: moraxu <[email protected]>
@moraxu
Copy link
Collaborator Author

moraxu commented May 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7104 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7104 [ run ] completed with state SUCCESS
/LLM/release-0.20/L0_MergeRequest_PR pipeline #148 completed with status: 'SUCCESS'

@moraxu
Copy link
Collaborator Author

moraxu commented May 31, 2025

@NVIDIA/trt-llm-release-branch-approval please hold off with the merge, I'm still trying to run those 2 tests locally, since they haven't been added to L0 for now

EDIT: Ready to merge

Signed-off-by: moraxu <[email protected]>
@moraxu
Copy link
Collaborator Author

moraxu commented May 31, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7124 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7124 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #7104 for commit 74b1965

Copy link
Collaborator

@schetlur-nv schetlur-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on offline conversation, the EP options never worked, and should not have been merged. This Mr is fixing that.

Signed-off-by: moraxu <[email protected]>
@moraxu
Copy link
Collaborator Author

moraxu commented Jun 2, 2025

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7238 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7238 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #7104 for commit 4a3dbf9

@schetlur-nv schetlur-nv merged commit 4e68be2 into NVIDIA:release/0.20 Jun 2, 2025
3 checks passed
omera-nv pushed a commit to omera-nv/TensorRT-LLM that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants