Skip to content

fix: Mapping rank boundary check bug #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

fix: Mapping rank boundary check bug #4935

merged 2 commits into from
Jun 26, 2025

Conversation

venkywonka
Copy link
Collaborator

fix rank validation logic in Mapping.rank

@venkywonka venkywonka marked this pull request as ready for review June 5, 2025 06:43
@venkywonka venkywonka requested review from QiJune and hlu1 June 5, 2025 06:46
QiJune
QiJune approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@venkywonka
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7650 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7650 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5558 completed with status: 'FAILURE'

@QiJune QiJune enabled auto-merge (squash) June 9, 2025 01:06
@QiJune
Copy link
Collaborator

QiJune commented Jun 9, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8060 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8060 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5844 completed with status: 'FAILURE'

auto-merge was automatically disabled June 11, 2025 20:06

Head branch was pushed to by a user without write access

@venkywonka venkywonka force-pushed the user/venky/mapping-check-minor-fix branch from 5e22507 to 4ffdfef Compare June 11, 2025 20:06
@venkywonka
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8544 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8544 [ run ] completed with state ABORTED

@venkywonka venkywonka force-pushed the user/venky/mapping-check-minor-fix branch from 4ffdfef to 6ff6348 Compare June 14, 2025 04:22
@venkywonka
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8872 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8872 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6459 completed with status: 'FAILURE'

@venkywonka venkywonka force-pushed the user/venky/mapping-check-minor-fix branch from 6ff6348 to 32d21bc Compare June 24, 2025 19:15
@venkywonka
Copy link
Collaborator Author

\bot run

@venkywonka
Fix rank check condition bug
e948728 
Signed-off-by: Venky <[email protected]>
@venkywonka
yapf
2e18e17 
Signed-off-by: Venky <[email protected]>
@venkywonka venkywonka force-pushed the user/venky/mapping-check-minor-fix branch from 32d21bc to 2e18e17 Compare June 26, 2025 19:30
@venkywonka
Copy link
Collaborator Author

/bot run

@venkywonka venkywonka enabled auto-merge (squash) June 26, 2025 19:31
@tensorrt-cicd
Copy link
Collaborator

PR_Github #10066 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #10066 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7431 completed with status: 'SUCCESS'

@venkywonka venkywonka merged commit 0083228 into NVIDIA:main Jun 26, 2025
3 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
4fdd5eb 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
6c897eb 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
8153871 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
7e2813e 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
83294d2 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
913bcc6 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
b8e8ff5 
Signed-off-by: Venky <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
@venkywonka @dominicshanshan
fix: Mapping rank boundary check bug (NVIDIA#4935)
b3a00ed 
Signed-off-by: Venky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@hlu1 hlu1 Awaiting requested review from hlu1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venkywonka @tensorrt-cicd @QiJune