Skip to content

Conversation

FrankD412
Copy link
Collaborator

Description

We encountered an issue where the performance regressed due to the fact that a tweak to our tuning equation only forces the maximum number of tokens to ISL when the tuning in bench finds a value less than ISL. That prevents the overlapping of generation and prefill requests in the executor causing an artificial bottleneck.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@FrankD412 FrankD412 self-assigned this Jun 5, 2025
@FrankD412 FrankD412 requested a review from a team as a code owner June 5, 2025 20:37
@FrankD412 FrankD412 force-pushed the fdinatale/trtllm_bench/fix_chunking branch from e587277 to 48eaa78 Compare June 5, 2025 20:39
Signed-off-by: Frank Di Natale <[email protected]>
Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn enabled auto-merge (squash) June 6, 2025 02:17
@kaiyux
Copy link
Member

kaiyux commented Jun 6, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7824 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7824 [ run ] completed with state SUCCESS
/LLM/release-0.20/L0_MergeRequest_PR pipeline #182 completed with status: 'SUCCESS'

@Superjomn Superjomn merged commit 6cbeb77 into NVIDIA:release/0.20 Jun 6, 2025
3 checks passed
@FrankD412 FrankD412 deleted the fdinatale/trtllm_bench/fix_chunking branch June 9, 2025 20:43
amirkl94 pushed a commit to amirkl94/TensorRT-LLM that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants