-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: support more parameters in openai worker of scaffolding #5115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more parameters in openai worker of scaffolding #5115
Conversation
Signed-off-by: Clay <[email protected]>
Signed-off-by: Clay <[email protected]>
Signed-off-by: Clay <[email protected]>
/bot run |
PR_Github #8914 [ run ] triggered by Bot |
PR_Github #8914 [ run ] completed with state |
Hi @WeiHaocheng, I noticed that I can't access the main Jenkins log (which I believe is expected), but I was able to check the log for "Upload test results" job on GitHub Actions. It failed with the error It looks like the root cause might be related to one of the test cases in the main pipeline, would you mind taking a look when you get a chance? Thanks a lot in advance! |
Hi @WeiHaocheng and @dc3671, Hope you're having a great week. Just wanted to gently follow up on this PR. I've kept the branch up-to-date with the latest It seems the main blockers are the pending review and the CI failure. The last CI run failed with a Please let me know if there's anything I can do to help resolve the CI issue, or if there's any other information needed from my side. Thanks again for your time and guidance! |
/bot run |
@ccs96307 Sorry for delay! Let me restart the CI pipeline. |
PR_Github #10836 [ run ] triggered by Bot |
Thank you so much @WeiHaocheng for the quick response and for restarting the pipeline! I’ll keep an eye on the CI results and will follow up immediately if any issues come up. Really appreciate your time and support~ |
PR_Github #10836 [ run ] completed with state |
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]>
…#5115) Signed-off-by: Clay <[email protected]> Signed-off-by: Yuxin <[email protected]>
PR title
[#3332][feat] Support more sampling parameters with openai worker
Description
Resolves #3332
This PR enhances the
OpenaiWorker
in the scaffolding framework by adding support for more sampling parameters.The
convert_task_params
method inworker.py
has been refactored to use a parameter list (OpenaiWorker
) for a cleaner and more maintainable implementation. This replaces a long series of repetitive function calls.To resolve a naming conflict, the input parameter for requesting log probabilities has been renamed to
num_logprobs
withinGenerationTask
. This distinguishes it from thelogprobs
attribute in the result fields. The worker mapsnum_logprobs
back to thelogprobs
key required by the OpenAI API.Please let me know if there's anything I should change, I'd be happy to update the PR accordingly.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...
Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]
to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]
Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast
(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test
(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"
(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"
(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test
(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test
(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test
(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge
(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"
(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
kill
Kill all running builds associated with pull request.
skip
skip --comment COMMENT
Skip testing for latest commit on pull request.
--comment "Reason for skipping build/test"
is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.