Skip to content

Conversation

litaotju
Copy link
Collaborator

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DeepSeek R1 performance documentation to include the latest release (v0.20) benchmarks for FP8 and FP16 KV caches.

  • Adds a new FP8 KV cache max-throughput section with reproduction commands and expected output format.
  • Refreshes FP16 KV cache performance numbers under the same commit.
  • Updates the table of contents to include these new subsections.
Comments suppressed due to low confidence (2)

docs/source/blogs/Best_perf_practice_on_DeepSeek-R1_in_TensorRT-LLM.md:191

  • Improve grammar: change "the numbers here is a reference" to "the numbers here are a reference" and consider rephrasing for clarity (e.g., "These numbers serve as a reference for the specified commit.").
!! Note that the exact command to reproduce numbers can change as the API/options are refactored, the numbers here is a reference at given exact commit.

docs/source/blogs/Best_perf_practice_on_DeepSeek-R1_in_TensorRT-LLM.md:213

  • Indent this line under pytorch_backend_config: so that enable_attention_dp is part of the same configuration block.
enable_attention_dp: true

@litaotju litaotju force-pushed the dev/tali/update-r1-perf branch from 02d5d55 to 694b751 Compare June 16, 2025 07:36
litaotju added 2 commits June 16, 2025 07:41
Signed-off-by: Tao Li <[email protected]>
@litaotju litaotju force-pushed the dev/tali/update-r1-perf branch from 007434e to 19d5b84 Compare June 16, 2025 07:41
Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs

litaotju and others added 3 commits June 16, 2025 16:55
…T-LLM.md

Co-authored-by: Kaiyu Xie <[email protected]>
Signed-off-by: Tao Li @ NVIDIA <[email protected]>
…T-LLM.md

Co-authored-by: Kaiyu Xie <[email protected]>
Signed-off-by: Tao Li @ NVIDIA <[email protected]>
…T-LLM.md

Co-authored-by: Kaiyu Xie <[email protected]>
Signed-off-by: Tao Li @ NVIDIA <[email protected]>
@litaotju litaotju merged commit 03f1a6a into NVIDIA:main Jun 16, 2025
2 checks passed
- 256
- 384
print_iter_log: true
pytorch_backend_config:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litaotju pytorch_backend_config was removed in #4603. Here you introduced them back in the doc. Is it intentional or just a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants